Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KMS: Updated for new client library #1903

Merged
merged 5 commits into from
Jan 7, 2019
Merged

KMS: Updated for new client library #1903

merged 5 commits into from
Jan 7, 2019

Conversation

daniel-sanche
Copy link
Member

Updated all samples to use the new libraries

tracking bug: b/120216809

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 5, 2018
engelke
engelke requested changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The asymmetric samples all have comments saying that they work on key IDs, but actually require key version IDs. The tests all work with key versions, so they pass.

Please address the comments and update.

@daniel-sanche
Copy link
Member Author

@engelke I addressed your comments, let me know if there's anything else

@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 7, 2019
@daniel-sanche daniel-sanche merged commit 6f9eacf into master Jan 7, 2019
@daniel-sanche daniel-sanche deleted the kms-gapic-update branch January 8, 2019 23:45
busunkim96 pushed a commit to googleapis/python-kms that referenced this pull request Jun 4, 2020
@daniel-sanche @busunkim96
KMS: Updated for new client library [(#1903)](GoogleCloudPlatform/pyt…
6ef75e2 
…hon-docs-samples#1903)

* updated kms samples to use new gapic client library
rsamborski pushed a commit that referenced this pull request Nov 8, 2022
@daniel-sanche @busunkim96
KMS: Updated for new client library [(#1903)](#1903)
72bbce4 
* updated kms samples to use new gapic client library
@rsamborski rsamborski mentioned this pull request Nov 8, 2022
Merged
8 tasks
rsamborski pushed a commit that referenced this pull request Nov 8, 2022
@daniel-sanche @rsamborski
KMS: Updated for new client library [(#1903)](#1903)
cc6b00e 
* updated kms samples to use new gapic client library
rsamborski pushed a commit that referenced this pull request Nov 11, 2022
@daniel-sanche @rsamborski
KMS: Updated for new client library [(#1903)](#1903)
1e40097 
* updated kms samples to use new gapic client library
rsamborski pushed a commit that referenced this pull request Nov 14, 2022
@daniel-sanche @rsamborski
KMS: Updated for new client library [(#1903)](#1903)
df03dc0 
* updated kms samples to use new gapic client library
dandhlee pushed a commit that referenced this pull request Nov 14, 2022
@daniel-sanche @dandhlee
KMS: Updated for new client library [(#1903)](#1903)
1e8220d 
* updated kms samples to use new gapic client library
parthea pushed a commit to googleapis/google-cloud-python that referenced this pull request Oct 21, 2023
@daniel-sanche @busunkim96
KMS: Updated for new client library [(#1903)](GoogleCloudPlatform/pyt…
620b210 
…hon-docs-samples#1903)

* updated kms samples to use new gapic client library
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelke engelke engelke approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@daniel-sanche @engelke @googlebot